bad request when voting on review

[drakaru]

Since the change from form data to json in 0.6.3 swarm responds 400 on vote.

If I revert the change in 0.6.3 to send form data instead, it works fine.

https://www.perforce.com/manuals/swarm/Content/Swarm/swarm-apidoc_endpoint_reviews.html#Set_vote_for_the_authenticated_user_to_up,_down,_or_cleared

Note I am using SWARM/2019.3/1886340 (2019/11/20) however the current docs don't mention json either.

[pbelskiy]

Thanks for report, will check it soon

@drakaru are you using sync client?

[pbelskiy]

It is strange, because even in old Swarm version (2017) docs says that it`s possible to put parameters as json in POST body - https://www.perforce.com/manuals/v17.4/swarm/#Swarm/swarm-apidoc.html

Used data instead of json for:

• reviews.vote()
• comments.add() (add check for topic)

[drakaru]

Interesting. I'm not sure.

Here's a small code sample to show all I'm doing:
I'm using api ver 9.

swarm_client = SwarmClient(
    f"{swarm_host}/api/v{swarm_api_ver}",
    swarm_api_user,
    swarm_api_ticket,
    verify=False,
)

swarm_client.reviews.vote(review_id, "up")

[pbelskiy]

@drakaru

Fixed in https://github.com/pbelskiy/helix-swarm/releases/tag/v0.6.4

[drakaru]

Grabbed latest and confirmed working here, thanks!