Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session_info in tags #184

Closed
pbiecek opened this issue Jan 27, 2016 · 6 comments
Closed

session_info in tags #184

pbiecek opened this issue Jan 27, 2016 · 6 comments
Assignees

Comments

@pbiecek
Copy link
Owner

pbiecek commented Jan 27, 2016

store detailed info about context in which the artifacts was created

@pbiecek
Copy link
Owner Author

pbiecek commented Jan 27, 2016

session_info from devtools or sessionInfo from utils?
First is more detailed but then we need to add devtools as dependency
@MarcinKosinski what do you think?

@MarcinKosinski
Copy link
Collaborator

We can use importFrom devtools aession_info or add this to suggests as we so we shiny in shinySearch.

Marcin Kosinski

Dnia 27.01.2016 o godz. 22:32 Przemysław Biecek notifications@github.com napisał(a):

session_info from devtools or sessionInfo from utils?
First is more detailed but then we need to add devtools as dependency
@MarcinKosinski what do you think?


Reply to this email directly or view it on GitHub.

@pbiecek
Copy link
Owner Author

pbiecek commented Jan 27, 2016

ok, good idea
first iteration is in 33ad2bc

@pbiecek
Copy link
Owner Author

pbiecek commented Jan 27, 2016

updated with c2ee345

@MarcinKosinski
Copy link
Collaborator

I've made a few updates, since you were importing session_info() from dplyr instead of devtools and I've added devtools to suggests in DESCRIPTION and in the .travis.yaml. I've also added a stop warning when one would try to use new archiveSessionInfo parameter but would not have devtools package. Could you maybe provide some tests for this new parameter - then I'll add this new feature to archive which works almost the same as saveToRepo ? [commits are above]

MarcinKosinski added a commit that referenced this issue Jan 28, 2016
@MarcinKosinski
Copy link
Collaborator

And I think, since devtools is in suggests and we have warning telling that the devtools is needed when it can not be required, then we can remove devtools from imports - as we do not import anything from shiny for shinySearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants