Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in the behaviour of createLocalRepo - the force argument #319

Closed
pbiecek opened this issue Nov 24, 2017 · 2 comments
Closed

change in the behaviour of createLocalRepo - the force argument #319

pbiecek opened this issue Nov 24, 2017 · 2 comments

Comments

@pbiecek
Copy link
Owner

@pbiecek pbiecek commented Nov 24, 2017

Currently, the force parameter in the createLocalRepo() function forces to create a new directory if one does not exist. But by default it's TRUE and I do not see why anyone would set it to FALSE.
As in #318 it is more natural to check the opposite.
Proposed behaviour:

  1. createLocalRepo() creates dir is one does not exist
  2. if directory exist and backpack.db is there, then force=TRUE is required to reinitialize the repository
  3. by default force=FALSE
pbiecek added a commit that referenced this issue Nov 24, 2017
@pbiecek pbiecek changed the title change in behaviour for createLocalRepo - the force argument change in the behaviour of createLocalRepo - the force argument Nov 24, 2017
@pbiecek
Copy link
Owner Author

@pbiecek pbiecek commented Nov 24, 2017

fixed with 03323a9
As soon as Travis finish all tests this version will be submitted to CRAN

@pbiecek
Copy link
Owner Author

@pbiecek pbiecek commented Nov 25, 2017

@pbiecek pbiecek closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.