This repository has been archived by the owner on Nov 15, 2020. It is now read-only.
If domain is not set, do not force as empty string. Breaks IE. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems legit. 👍 |
|
@pboling any chance this can get merged? |
|
Yeah. Merging. |
pboling
added a commit
that referenced
this pull request
Sep 28, 2015
If domain is not set, do not force as empty string. Breaks IE.
|
Released in 0.3.4: https://rubygems.org/gems/cacheable_flash |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pathouse can you explain #25 a bit? I know this repo is pretty old but I think the merged PR breaks Internet Explorer if a domain is not explicitly set. A set-cookie header does not need quotes.
If domain is explicitly set, master + this PR both render...
But if domain is nil, master renders... (does not work in IE)
While this PR renders...