🔨 Regenerate Appraisals

pboling · Apr 25, 2024 · 869455f · 869455f
1 parent 6245fbc
commit 869455f
Show file tree

Hide file tree

Showing 14 changed files with 95 additions and 53 deletions.
diff --git a/.rubocop_gradual.lock b/.rubocop_gradual.lock
@@ -10,17 +10,8 @@
   "init.rb:3429808413": [
     [3, 9, 16, "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", 29970817]
   ],
-  "lib/sanitize_email.rb:1771666431": [
-    [51, 3, 110, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 244581949],
-    [56, 3, 67, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 4112587574],
-    [56, 3, 67, "Style/MissingRespondToMissing: When using `method_missing`, define `respond_to_missing?`.", 4112587574],
-    [62, 3, 148, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1610211115],
-    [68, 3, 87, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1634519225],
-    [72, 3, 141, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1031065844],
-    [78, 5, 29, "ThreadSafety/ClassAndModuleAttributes: Avoid mutating class and module attributes.", 1399760671],
-    [97, 3, 354, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 2628092758],
-    [119, 3, 184, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 2216955970],
-    [126, 3, 287, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1344355207]
+  "lib/sanitize_email.rb:3334182494": [
+    [57, 5, 29, "ThreadSafety/ClassAndModuleAttributes: Avoid mutating class and module attributes.", 1399760671]
   ],
   "lib/sanitize_email/config.rb:393256477": [
     [13, 7, 21, "ThreadSafety/ClassAndModuleAttributes: Avoid mutating class and module attributes.", 622027168],
@@ -49,7 +40,7 @@
     [65, 5, 233, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 2880787383],
     [73, 5, 386, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1085137330]
   ],
-  "spec/sanitize_email_spec.rb:3508591302": [
+  "spec/sanitize_email_spec.rb:3223811398": [
     [7, 3, 280, "RSpec/LeakyConstantDeclaration: Stub constant instead of declaring explicitly.", 1223327],
     [114, 15, 19, "RSpec/VariableName: Use snake_case for variable names.", 372347066],
     [123, 15, 19, "RSpec/VariableName: Use snake_case for variable names.", 372347066],

diff --git a/Appraisals b/Appraisals
@@ -7,34 +7,59 @@
 # Test Matrix:
 #   - Ruby 2.3
 appraise "rails-4-0" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 4.0.13"
   gem "railties", "~> 4.0.13"
+  gem "actionpack", "~> 4.0.13"
+  gem "rdoc", "6.1.2.1"
+  gem "json", ">= 1.7.7", "~> 1.7"
+  gem "rspec-rails", "~> 3.0" # For Rails 4
 end
 
 # Compat: Ruby >= 1.9.3
 # Test Matrix:
 #   - Ruby 2.3
 appraise "rails-4-1" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 4.1.16"
   gem "railties", "~> 4.1.16"
+  gem "actionpack", "~> 4.1.16"
+  gem "rdoc", "6.1.2.1"
+  gem "json", ">= 1.7.7", "~> 1.7"
+  gem "rspec-rails", "~> 3.0" # For Rails 4
 end
 
 # Compat: Ruby >= 1.9.3
 # Test Matrix:
 #   - Ruby 2.3
 #   - Ruby 2.4
 appraise "rails-4-2" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 4.2.11.3"
   gem "railties", "~> 4.2.11.3"
+  gem "actionpack", "~> 4.2.11.3"
+  gem "rdoc", "6.1.2.1"
+  gem "rspec-rails", "~> 3.0" # For Rails 4
 end
 
 # Compat: Ruby >= 2.2.2
 # Test Matrix:
 #   - Ruby 2.3
 #   - Ruby 2.4
 appraise "rails-5-0" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 5.0.7.2"
   gem "railties", "~> 5.0.7.2"
+  gem "actionpack", "~> 5.0.7.2"
+  gem "rspec-rails", "~> 4.0" # For Rails 5.0 & 5.1
 end
 
 # Compat: Ruby >= 2.2.2
@@ -43,8 +68,13 @@ end
 #   - Ruby 2.4
 #   - Ruby 2.5
 appraise "rails-5-1" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 5.1.7"
   gem "railties", "~> 5.1.7"
+  gem "actionpack", "~> 5.1.7"
+  gem "rspec-rails", "~> 4.0" # For Rails 5.0 & 5.1
 end
 
 # Compat: Ruby >= 2.2.2
@@ -55,8 +85,13 @@ end
 #   - Ruby 2.6
 #   - Ruby 2.7
 appraise "rails-5-2" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 5.2.8.1"
   gem "railties", "~> 5.2.8.1"
+  gem "actionpack", "~> 5.2.8.1"
+  gem "rspec-rails", "~> 5.0" # For Rails 5.2 & Rails 6.0
 end
 
 # Compat: Ruby >= 2.5
@@ -65,8 +100,13 @@ end
 #   - Ruby 2.6
 #   - Ruby 2.7
 appraise "rails-6-0" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 6.0.6.1"
   gem "railties", "~> 6.0.6.1"
+  gem "actionpack", "~> 6.0.6.1"
+  gem "rspec-rails", "~> 5.0" # For Rails 5.2 & Rails 6.0
 end
 
 # Compat: Ruby >= 2.5
@@ -76,8 +116,13 @@ end
 #   - Ruby 2.7
 #   - Ruby 3.0
 appraise "rails-6-1" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 6.1.7.7"
   gem "railties", "~> 6.1.7.7"
+  gem "actionpack", "~> 6.1.7.7"
+  gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
 end
 
 # Compat: Ruby >= 2.7
@@ -86,8 +131,13 @@ end
 #   - Ruby 3.0
 #   - Ruby 3.1
 appraise "rails-7-0" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 7.0.8.1"
   gem "railties", "~> 7.0.8.1"
+  gem "actionpack", "~> 7.0.8.1"
+  gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
 end
 
 # Compat: Ruby >= 2.7
@@ -97,6 +147,11 @@ end
 #   - Ruby 3.1
 #   - Ruby 3.2
 appraise "rails-7-1" do
+  # Load order is very important with combustion!
+  gem "combustion", "~> 1.4"
+
   gem "actionmailer", "~> 7.1.3.2"
   gem "railties", "~> 7.1.3.2"
+  gem "actionpack", "~> 7.1.3.2"
+  gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
 end
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -7,6 +7,14 @@ the [code of conduct][🤝conduct].
 To submit a patch, please fork the project and create a patch with tests. Once you're happy with it send a pull request
 and post a message to the [gitter chat][🏘chat].
 
+## Appraisal & Combustion
+
+### Generate a new set of Appraisal gemfiles:
+
+```sh
+BUNDLE_GEMFILE=gemfiles/vanilla.gemfile appraisal generate
+```
+
 ## Release
 
 To release a new version:

diff --git a/gemfiles/rails_4_0.gemfile b/gemfiles/rails_4_0.gemfile
@@ -2,14 +2,12 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 4.0.13"
 gem "railties", "~> 4.0.13"
 gem "actionpack", "~> 4.0.13"
+gem "rspec-rails", "~> 3.0"
 gem "rdoc", "6.1.2.1"
 gem "json", ">= 1.7.7", "~> 1.7"
-gem "rspec-rails", "~> 3.0" # For Rails 4
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_4_1.gemfile b/gemfiles/rails_4_1.gemfile
@@ -2,14 +2,12 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 4.1.16"
 gem "railties", "~> 4.1.16"
 gem "actionpack", "~> 4.1.16"
+gem "rspec-rails", "~> 3.0"
 gem "rdoc", "6.1.2.1"
 gem "json", ">= 1.7.7", "~> 1.7"
-gem "rspec-rails", "~> 3.0" # For Rails 4
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_4_2.gemfile b/gemfiles/rails_4_2.gemfile
@@ -2,13 +2,11 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 4.2.11.3"
 gem "railties", "~> 4.2.11.3"
 gem "actionpack", "~> 4.2.11.3"
+gem "rspec-rails", "~> 3.0"
 gem "rdoc", "6.1.2.1"
-gem "rspec-rails", "~> 3.0" # For Rails 4
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_5_0.gemfile b/gemfiles/rails_5_0.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 5.0.7.2"
 gem "railties", "~> 5.0.7.2"
 gem "actionpack", "~> 5.0.7.2"
-gem "rspec-rails", "~> 4.0" # For Rails 5.0 & 5.1
+gem "rspec-rails", "~> 4.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_5_1.gemfile b/gemfiles/rails_5_1.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 5.1.7"
 gem "railties", "~> 5.1.7"
 gem "actionpack", "~> 5.1.7"
-gem "rspec-rails", "~> 4.0" # For Rails 5.0 & 5.1
+gem "rspec-rails", "~> 4.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_5_2.gemfile b/gemfiles/rails_5_2.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 5.2.8.1"
 gem "railties", "~> 5.2.8.1"
 gem "actionpack", "~> 5.2.8.1"
-gem "rspec-rails", "~> 5.0" # For Rails 5.2 & Rails 6.0
+gem "rspec-rails", "~> 5.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_6_0.gemfile b/gemfiles/rails_6_0.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 6.0.6.1"
 gem "railties", "~> 6.0.6.1"
 gem "actionpack", "~> 6.0.6.1"
-gem "rspec-rails", "~> 5.0" # For Rails 5.2 & Rails 6.0
+gem "rspec-rails", "~> 5.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_6_1.gemfile b/gemfiles/rails_6_1.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 6.1.7.7"
 gem "railties", "~> 6.1.7.7"
 gem "actionpack", "~> 6.1.7.7"
-gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
+gem "rspec-rails", "~> 6.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_7_0.gemfile b/gemfiles/rails_7_0.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 7.0.8.1"
 gem "railties", "~> 7.0.8.1"
 gem "actionpack", "~> 7.0.8.1"
-gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
+gem "rspec-rails", "~> 6.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/gemfiles/rails_7_1.gemfile b/gemfiles/rails_7_1.gemfile
@@ -2,12 +2,10 @@
 
 source "https://rubygems.org"
 
-# Load order is very important with combustion!
 gem "combustion", "~> 1.4"
-
 gem "actionmailer", "~> 7.1.3.2"
 gem "railties", "~> 7.1.3.2"
 gem "actionpack", "~> 7.1.3.2"
-gem "rspec-rails", "~> 6.0" # For Rails 6.1 & Rails 7.0 - 7.1
+gem "rspec-rails", "~> 6.0"
 
-gemspec path: "../"
+gemspec path: "../../"
diff --git a/lib/sanitize_email.rb b/lib/sanitize_email.rb
@@ -62,7 +62,15 @@ def [](key)
     end
 
     def method_missing(name, *_args)
-      SanitizeEmail[name]
+      if name
+        SanitizeEmail[name]
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(method_name, include_private = false)
+      method_name ? method_name : super
     end
 
     # NOTE: Deprecated method