Skip to content

Commit

Permalink
✅ Add back Rails 3.0-, 3.1, 3.2
Browse files Browse the repository at this point in the history
  • Loading branch information
pboling committed Apr 25, 2024
1 parent 8925274 commit de55a08
Show file tree
Hide file tree
Showing 6 changed files with 87 additions and 46 deletions.
28 changes: 16 additions & 12 deletions .github/workflows/ancient.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Rails 4 on EOL Ruby 2.3 - 2.4
name: Rails 3 - 4.1 on EOL Ruby 2.3

on:
push:
Expand Down Expand Up @@ -34,31 +34,35 @@ jobs:
fail-fast: false
matrix:
include:
- ruby: "2.4"
- ruby: "2.3"
experimental: true
appraisal: "rails-4-2"
rubygems: "3.3.27"
appraisal: "rails-4-1"
bundler: '1.17.3'
gemfile: vanilla
rails: "4.2"
rails: "4.1"
- ruby: "2.3"
appraisal: "rails-4-0"
bundler: '1.17.3'
gemfile: vanilla
rails: "4.0"
- ruby: "2.3"
experimental: true
appraisal: "rails-4-2"
rubygems: "3.3.27"
appraisal: "rails-3-2"
bundler: '1.17.3'
gemfile: vanilla
rails: "4.2"
rails: "3.2"
- ruby: "2.3"
experimental: true
appraisal: "rails-4-1"
appraisal: "rails-3-1"
bundler: '1.17.3'
gemfile: vanilla
rails: "4.1"
rails: "3.1"
- ruby: "2.3"
appraisal: "rails-4-0"
experimental: true
appraisal: "rails-3-0"
bundler: '1.17.3'
gemfile: vanilla
rails: "4.0"
rails: "3.0"
runs-on: ubuntu-20.04
continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
steps:
Expand Down
38 changes: 4 additions & 34 deletions .github/workflows/legacy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Rails 5, 6, 7 on EOL Ruby 2.3 - 3.0
name: Rails 4.2, 5, 6, 7 on EOL Ruby 2.5 - 3.0

on:
push:
Expand Down Expand Up @@ -124,42 +124,12 @@ jobs:
bundler: none
gemfile: vanilla
rails: "5.1"
- ruby: "2.4"
appraisal: "rails-5-2"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.2"
- ruby: "2.4"
appraisal: "rails-5-1"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.1"
- ruby: "2.4"
appraisal: "rails-5-0"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.0"
- ruby: "2.3"
appraisal: "rails-5-2"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.2"
- ruby: "2.3"
appraisal: "rails-5-1"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.1"
- ruby: "2.3"
appraisal: "rails-5-0"
- ruby: "2.5"
appraisal: "rails-4-2"
rubygems: "3.3.27"
bundler: none
gemfile: vanilla
rails: "5.0"
rails: "4.2"
runs-on: ubuntu-20.04
continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
steps:
Expand Down
26 changes: 26 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,32 @@
# NOTE(2024-04-24): Current release of rake v13 supports Ruby >= 2.3
# NOTE(2024-04-24): Current release of json v2 supports Ruby >= 2.3

appraise "rails-3-0" do
gem "rails", "~> 3.0.0"
gem "reek", "~> 2.0" # for Ruby < 2.0
gem "tins", "~> 1.6.0" # for Ruby < 2.0
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"
gem "rest-client", "~> 1.8.0"
end
appraise "rails-3-1" do
gem "actionmailer", "~> 3.1.0"
gem "railties", "~> 3.1.0"
gem "reek", "~> 2.0" # for Ruby < 2.0
gem "tins", "~> 1.6.0" # for Ruby < 2.0
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"
gem "rest-client", "~> 1.8.0"
end
appraise "rails-3-2" do
gem "actionmailer", "~> 3.2.0"
gem "railties", "~> 3.2.0"
# reek >= 4.0 requires Ruby 2.1 minimum
gem "reek", "~>3.11.0"
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"
end

# Compat: Ruby >= 1.9.3
# Test Matrix:
# - Ruby 2.3
Expand Down
15 changes: 15 additions & 0 deletions gemfiles/rails_3_0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "combustion", "~> 1.4"
gem "actionmailer"
gem "railties"
gem "rails", "~> 3.0.0"
gem "reek", "~> 2.0"
gem "tins", "~> 1.6.0"
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"
gem "rest-client", "~> 1.8.0"

gemspec path: "../"
14 changes: 14 additions & 0 deletions gemfiles/rails_3_1.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "combustion", "~> 1.4"
gem "actionmailer", "~> 3.1.0"
gem "railties", "~> 3.1.0"
gem "reek", "~> 2.0"
gem "tins", "~> 1.6.0"
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"
gem "rest-client", "~> 1.8.0"

gemspec path: "../"
12 changes: 12 additions & 0 deletions gemfiles/rails_3_2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "combustion", "~> 1.4"
gem "actionmailer", "~> 3.2.0"
gem "railties", "~> 3.2.0"
gem "reek", "~>3.11.0"
gem "json", "~> 1.8.3"
gem "rake", "~> 11.2.2"

gemspec path: "../"

0 comments on commit de55a08

Please sign in to comment.