Timeout tests and GOROOT again #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also minor formatting.
Also: - Change "antlr4" imports to "github.com/antlr/antlr4/runtime/Go/antlr" - Remove parser prefix from Property and pred calls - Change TParser.X tokens to TParserX
|
I tried to cherry-pick 9cb4c66, but it seems I am too noob for git. |
|
see #15 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #9 (9562d87), because as anticipated #4 broke the test target (a bit more).
Timeout helps a bit with #7.
Also I've piggy backed yet another change at finding the go tool. Setting
$GOROOTis discouraged, though setting it is necessary if you install the binary go dist to a non-default location. (That never occured to me, because I've compiled go from source since day one.) In that case,$GOROOTshould be honoured as the primary location, not as last resort. In order to engineer this to death we could do this search in a@BeforeClass... ;D