Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to three conversion: avoid RangeErrors when dealing with large arrays #29

Merged
merged 1 commit into from
Jun 25, 2016

Conversation

uqee
Copy link
Contributor

@uqee uqee commented Jun 22, 2016

Current implementation: destinationArray.push.apply(destinationArray, sourceArray); fails to process large arrays (at least it fails at ~130k elements for me) with the RangeError: Maximum call stack size exceeded. Since neither threePts nor threeFaces is actually used later, they just duplicate memory consumption and can be removed in favor of direct geometry.vertices and geometry.faces manipulation.

@pboyer
Copy link
Owner

pboyer commented Jun 25, 2016

Thanks @uqee! Looks good.

@pboyer pboyer merged commit 6e346e8 into pboyer:master Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants