to three conversion: avoid RangeErrors when dealing with large arrays #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation:
destinationArray.push.apply(destinationArray, sourceArray);
fails to process large arrays (at least it fails at ~130k elements for me) with theRangeError: Maximum call stack size exceeded
. Since neitherthreePts
northreeFaces
is actually used later, they just duplicate memory consumption and can be removed in favor of directgeometry.vertices
andgeometry.faces
manipulation.