Bump Pandoc dependency #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack lts 8.0 ships with Pandoc 1.19.2.1, which is outside our existing dependency graph. That means that end users that want to use this package need to define a number of additional dependencies for their stack projects if they wish (or need) to use 8.0. Bumping the dependency here will allow users to simply add yesod-markdown as a dependency, without needing to change the version of Pandoc they use.
pbrisbin
approved these changes
Feb 13, 2017
src/Yesod/Markdown.hs
Outdated
| @@ -50,7 +50,6 @@ import Text.Blaze.Html (preEscapedToMarkup) | |||
| import Text.HTML.SanitizeXSS (sanitizeBalance) | |||
| import Text.Hamlet (hamlet, Html) | |||
| import Text.Pandoc | |||
| import Text.Pandoc.Error | |||
There was a problem hiding this comment.
Does this removal mean we have to bump our lower bounds? I.e. was it needed at earlier versions then became a re-export later?
There was a problem hiding this comment.
Yeah, it appears this would require us to bump the lower bounds as well. I'll remove this commit, since it's not really necessary.
|
Uploaded as v0.11.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack lts 8.0 ships with Pandoc 1.19.2.1, which is outside our existing
dependency graph. That means that end users that want to use this package
need to define a number of additional dependencies for their stack projects
if they wish (or need) to use 8.0.
Bumping the dependency here will allow users to simply add yesod-markdown
as a dependency, without needing to change the version of Pandoc they use.
Also removing an unused import while I'm in here mucking around.