Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not resolving const FOO = Bar::class #50

Closed
norrs opened this issue Sep 3, 2015 · 9 comments
Closed

Not resolving const FOO = Bar::class #50

norrs opened this issue Sep 3, 2015 · 9 comments

Comments

@norrs
Copy link

norrs commented Sep 3, 2015

git clone https://github.com/norrs/dynamic_issue

see Fail.php, why doesn't $thisShouldBeBar resolve?

@pbyrne84
Copy link
Owner

pbyrne84 commented Sep 3, 2015

Cool, thanks for the example I could checkout it is a big big help as the big test environment is great for checking stability as new versions of intellij etc come out but so big now not so fun trying to figure out these little edge cases as there is not real documentation on this stuff. I never envisioned class constants assigned to class constants which would then alias to ::class somewhere.

Anyway it took me a little while but I have found it is doable.

Cheers

@norrs
Copy link
Author

norrs commented Sep 4, 2015

Do you have an estimated time frame for when this could be fixed? Would greatly help phpstorm's introspection in our project. Can I personally sponsor you somehow via paypal etc?

Else thanks for your work and great plugin! :-)

@pbyrne84
Copy link
Owner

pbyrne84 commented Sep 4, 2015

Well I have fixed your edge case but now I need to re-add my edge cases and
try to make it recursive so it can go down more than 1 level. So you are
looking at tonight/monday night

On 4 September 2015 at 10:35, Roy Sindre Norangshol <
notifications@github.com> wrote:

Do you have an estimated time frame for when this could be fixed? Would
greatly help phpstorm's introspection in our project. Can I personally
sponsor you somehow via paypal etc?

Else thanks for your work and great plugin! :-)


Reply to this email directly or view it on GitHub
#50 (comment)
.

@pbyrne84
Copy link
Owner

pbyrne84 commented Sep 4, 2015

Always those cases are resolved but I have to wait to monday. In theory it will keep on trucking until it finds something it can make sense of.

@norrs
Copy link
Author

norrs commented Sep 7, 2015

Thanks! Our use case is that we have a configuration file and some reflection "magic" to initialize defined service interfaces defined in a services interface with constants.
( in case you were curious what my use case was )

@pbyrne84
Copy link
Owner

pbyrne84 commented Sep 7, 2015

Should be done

@norrs
Copy link
Author

norrs commented Sep 7, 2015

@pbyrne84 : Thanks, I'll give it a spin at work tomorrow and let you know 👍

@norrs
Copy link
Author

norrs commented Sep 8, 2015

Confirmed it to be working! Thanks! :-)

@norrs norrs closed this as completed Sep 8, 2015
@pbyrne84
Copy link
Owner

pbyrne84 commented Sep 8, 2015

Nice...

On 8 September 2015 at 09:13, Roy Sindre Norangshol <
notifications@github.com> wrote:

Closed #50 #50
.


Reply to this email directly or view it on GitHub
#50 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants