Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Enhancement: Ability to block spawns that happen immediately at chunk generation #13

Closed
ninjakitty844 opened this issue Feb 13, 2023 · 1 comment · Fixed by #27
Labels
enhancement New feature or request

Comments

@ninjakitty844
Copy link

This mod currently blocks random natural mob spawns that happen over time. It currently does not block spawns that happen during initial chunk generation. There may be a use case for only blocking natural spawns over time and not chunk gen spawns, in which case I think the player should have the choice to choose. (for example, if you want to block natural piglin spawns, but let them still spawn in bastions)

I have two ideas for how this could be executed (one or the other would work, not both at same time).

  1. Per rule, you specify (maybe in conditions?) whether you are targeting chunk gen spawns or random spawns. (both by default, unless otherwise specified)
  2. A global true/false option in the configuration file which would affect all your targeting to either include or not include chunk gen spawns. Something like "includeChunkGenerationSpawns: " which would be either true or false

And then regardless what is/isn't changed, a little documentation should be added in the default config to explain it so it is clear how this all works.

@pcal43 pcal43 added the enhancement New feature or request label Sep 26, 2023
pcal43 added a commit that referenced this issue Oct 24, 2023
pcal43 added a commit that referenced this issue Oct 24, 2023
pcal43 added a commit that referenced this issue Oct 24, 2023
@pcal43
Copy link
Owner

pcal43 commented Oct 24, 2023

should be working now courtesy of @ILikeFood971 . i opted to not bother with the config switch - i think most folks just want the rules to apply all the time.

@pcal43 pcal43 closed this as completed Oct 24, 2023
pcal43 added a commit that referenced this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants