Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spikes #439

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Spikes #439

merged 1 commit into from
Jun 26, 2020

Conversation

eyal0
Copy link
Contributor

@eyal0 eyal0 commented Jun 19, 2020

No description provided.

@eyal0 eyal0 force-pushed the spikes branch 2 times, most recently from bab31ab to f48ec81 Compare June 22, 2020 21:38
@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2020

Coverage Status

Coverage increased (+0.2%) to 68.369% when pulling 328489b on eyal0:spikes into df9db6c on pcb2gcode:master.

@eyal0 eyal0 force-pushed the spikes branch 2 times, most recently from f874618 to 7ce8fbe Compare June 26, 2020 04:23
@eyal0
Copy link
Contributor Author

eyal0 commented Jun 26, 2020

Spikes is a funny name for a feature that will fill in gaps in your milling when you are using multiple milling bits.

Here's the problem: Say you have a pretty big milling bit trying to get into a tight corner and you want to have more isolation than your bit will provide, so you need to make two passes:

image

The trace is in dark green. You can see that the first pass wasn't able to tuck into the corner. That makes sense because the bit is too large to fit in there. The project specified 10% overlap so the next pass is supposed to overlap by 10%, and it does! But look at the corner. Even though the first pass was unable to tuck into there, the second pass should be able to do!

The way that passes are made, by enlarging the ring around the trace, is a problem in these tight corners because it makes a pass that guarantees a 10% overlap or less. What we really want is a 10% overlap or more. That's where the spikes come in. When an inside corner is detected, a little bit of milling is added to clear out the corner. It sticks out until it is within 10% overlap of that inside corner, as configured.

image

Notice that only the inside corner needs a spike. For voronoi passes and thermals, the rule is reversed.

When extra passes are needed with a requested overlap, the overlap on
an inside corner isn't sufficient.  Add a small "spike" in and back
out of each such corner so that the proper minimum milling overlap is
maintained.
@eyal0 eyal0 merged commit e8ed093 into pcb2gcode:master Jun 26, 2020
@eyal0 eyal0 deleted the spikes branch June 26, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants