Limit spike length to the nearest trace. #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
eyal0
force-pushed
the
fix_spikes
branch
2 times, most recently
from
b0bcfc5
to
1b7b1a3
Compare
|
This will fix #412 where the spikes were too long. |
eyal0
force-pushed
the
fix_spikes
branch
3 times, most recently
from
60a5efe
to
dc0fc2b
Compare
This is just in case the buffer operation creates a sharp corner that leads to a very long spike, for example, if a very sharp corner is created from a narrow trapezoid that is bg::buffered. All spikes are limited to not cross any other trace that needs to be drawn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just in case the buffer operation creates a sharp corner that
leads to a very long spike, for example, if a very sharp corner is
created from a narrow trapezoid that is bg::buffered. All spikes are
limited to not cross any other trace that needs to be drawn.