Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly specify X/Y to G2. #48

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Clearly specify X/Y to G2. #48

merged 1 commit into from
Aug 19, 2016

Conversation

cho45
Copy link
Contributor

@cho45 cho45 commented Aug 18, 2016

Grbl does not move without X/Y in G2. (ref https://github.com/grbl/grbl/blob/0427fd5/grbl/gcode.c#L684 Block without X/YZ/ is ignored...)

This patch just adds current X/Y to G2.

This may be fixed in grbl side. But this generates more versatile gcode with no side effects.

@corna
Copy link
Member

corna commented Aug 18, 2016

I tested it with LinuxCNC and it works correctly.
With Mach3 an axis word is probably mandatory (see here, "When the XY-plane is selected [...]. The axis words are all optional except that at least one of X and Y must be used."), therefore you should change the commit message to something more generic (like "add explicit X/Y coordinates during G2 movements")

(Eg. Grbl does not move without X/Y in G2.)
@corna corna merged commit 0fc5617 into pcb2gcode:master Aug 19, 2016
@corna
Copy link
Member

corna commented Aug 19, 2016

Merged, thanks

@cho45
Copy link
Contributor Author

cho45 commented Aug 19, 2016

Thank you for fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants