Only read block devices during cache discovery (openzfs#469)

pcd1193182 · Jun 6, 2022 · 50ab6e1 · 50ab6e1
1 parent a5fb50f
commit 50ab6e1
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/cmd/zfs_object_agent/zettacache/src/open.rs b/cmd/zfs_object_agent/zettacache/src/open.rs
@@ -1,6 +1,7 @@
 use std::collections::BTreeMap;
 use std::collections::HashMap;
 use std::collections::HashSet;
+use std::os::unix::fs::FileTypeExt;
 use std::path::Path;
 use std::path::PathBuf;
 
@@ -56,6 +57,12 @@ impl DiscoveredDevice {
         let mut file = File::open(&path)
             .await
             .with_context(|| format!("open {path:?}"))?;
+
+        let filetype = file.metadata().await?.file_type();
+        if !filetype.is_block_device() && !filetype.is_file() {
+            return Err(anyhow!("{path:?} is not a file nor a block device"));
+        }
+
         let mut buf = vec![0u8; SUPERBLOCK_SIZE];
         file.read_exact(&mut buf)
             .await