Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small misnamed param in openapi spec #133

Closed
cdalong opened this issue May 6, 2024 · 3 comments · Fixed by #134
Closed

Small misnamed param in openapi spec #133

cdalong opened this issue May 6, 2024 · 3 comments · Fixed by #134

Comments

@cdalong
Copy link

cdalong commented May 6, 2024

The 'Provinces' block of the openapi spec has mis-named "holidays" for "provinces" so using the /provinces/{provinceId} API results in null holidays

I'd raise a PR, but don't have access rights. -- but on line 792 of the openapi spec:

        provinces:
          type: array
          items:
            $ref: '#/components/schemas/Holiday'

should be:

        holidays:
          type: array
          items:
            $ref: '#/components/schemas/Holiday'

of the #/components/schemas/Province object

@cdalong
Copy link
Author

cdalong commented May 6, 2024

or excuse me, should have a holidays definition altogether

@pcraig3
Copy link
Owner

pcraig3 commented May 7, 2024

Good catch! I'll push a fix later today.

pcraig3 added a commit that referenced this issue May 7, 2024
This was brought up by @cdalong in #133

Easy fix!
@cdalong
Copy link
Author

cdalong commented May 27, 2024

Thanks man! really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants