We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 'Provinces' block of the openapi spec has mis-named "holidays" for "provinces" so using the /provinces/{provinceId} API results in null holidays
I'd raise a PR, but don't have access rights. -- but on line 792 of the openapi spec:
provinces: type: array items: $ref: '#/components/schemas/Holiday'
should be:
holidays: type: array items: $ref: '#/components/schemas/Holiday'
of the #/components/schemas/Province object
The text was updated successfully, but these errors were encountered:
or excuse me, should have a holidays definition altogether
Sorry, something went wrong.
Good catch! I'll push a fix later today.
Update API schema to correct key name
a0d18ce
This was brought up by @cdalong in #133 Easy fix!
Thanks man! really appreciate it
Successfully merging a pull request may close this issue.
The 'Provinces' block of the openapi spec has mis-named "holidays" for "provinces" so using the /provinces/{provinceId} API results in null holidays
I'd raise a PR, but don't have access rights. -- but on line 792 of the openapi spec:
should be:
of the #/components/schemas/Province object
The text was updated successfully, but these errors were encountered: