Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new holibobs for Day of Mourning #124

Merged
merged 1 commit into from Sep 13, 2022
Merged

Add new holibobs for Day of Mourning #124

merged 1 commit into from Sep 13, 2022

Conversation

pcraig3
Copy link
Owner

@pcraig3 pcraig3 commented Sep 13, 2022

We are getting a new one-time (at least) federal holiday this year, the Day of Mourning to commemorate the passing of the Queen. As of this point, it's just for federal employees, but provinces may also come on board.

This is a one-time holiday, it will not be observed in past years or next year.

Here's the article: https://www.cbc.ca/news/politics/queen-funeral-national-holiday-or-not-1.6580582

Notes

  • The previous commit I had where I added Truth and Reconciliation was great here: https://github.com/pcraig3/hols/pull/94/files
  • Added a new nullable field (lastOccurence)
    • Essentially, this holiday is first observed this year and last observed this year.
    • No other holidays are using this field yet, but who can say what will happen in the future?

Screenshot

New screenshot has the new holiday.

before after
Screen Shot 2022-09-13 at 17 22 47 Screen Shot 2022-09-13 at 17 22 35

@pcraig3 pcraig3 merged commit 4856805 into main Sep 13, 2022
@pcraig3 pcraig3 deleted the day-of-mourning branch September 13, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant