Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation issue #1

Closed
borisdayma opened this issue Jul 13, 2022 · 3 comments
Closed

Installation issue #1

borisdayma opened this issue Jul 13, 2022 · 3 comments

Comments

@borisdayma
Copy link

To install it, I had to install flaxmodels per the repo instructions with pip install --upgrade git+https://github.com/matthias-wright/flaxmodels.git

I think the pypi package may be too old.
pcuenca added a commit that referenced this issue Jul 13, 2022
@pcuenca
Add instructions to install from repo.
6fb6dc2 
Installing from PyPI does not work as we can't install flaxmodels from
its repo, even when using a source distribution.

Addresses #1.
@pcuenca
Copy link
Owner

pcuenca commented Jul 13, 2022

You are right. Sorry.

I didn't know how PyPI works and you can't use a URL dependency, even when building a source distribution. Therefore, this package has to be installed from the repo too. I added an installation section to the README file to clarify:

  1. Install JAX for CUDA or TPU following the instructions at https://github.com/google/jax#installation.
  2. Install this package from the repository: 
    pip install --upgrade git+https://github.com/pcuenca/lpips-j.git

Alternatives:

  • Wait for flaxmodels to update their PyPI distribution (if possible, maybe they are facing a similar obstacle).
  • Remove the flaxmodels dependency by implementing vgg16 inside this package. It's a shame, as I really like their code and am keen on leveraging and acknowledging other people's work.

@borisdayma
Copy link
Author

Maybe we can just ask them?

@pcuenca pcuenca mentioned this issue Jul 14, 2022
Closed
@pcuenca
Copy link
Owner

pcuenca commented Jul 14, 2022

flaxmodels updated their package, installation should proceed fine now.

@pcuenca pcuenca closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borisdayma @pcuenca