Skip to content

Commit

Permalink
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
Browse files Browse the repository at this point in the history
  • Loading branch information
pdanpdan committed Jul 9, 2020
1 parent a8be627 commit 2b013c3
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions ui/src/components/select/QSelect.js
Expand Up @@ -1050,11 +1050,14 @@ export default Vue.extend({

this.$nextTick(() => {
this.innerLoading = false
if (this.menu === true) {
this.__updateMenu(true)
}
else {
this.menu = true

if (this.editable === true) {
if (this.menu === true) {
this.__updateMenu(true)
}
else {
this.menu = true
}
}

typeof afterFn === 'function' && this.$nextTick(() => { afterFn(this) })
Expand Down Expand Up @@ -1290,6 +1293,10 @@ export default Vue.extend({
},

showPopup (e) {
if (this.editable !== true) {
return
}

if (this.hasDialog === true) {
this.__onControlFocusin(e)
this.dialog = true
Expand Down

0 comments on commit 2b013c3

Please sign in to comment.