PHPDoc cleanup #587
Merged
PHPDoc cleanup #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<?php /* * This document has been generated with * https://mlocati.github.io/php-cs-fixer-configurator/#version:3.4.0|configurator * you can change this configuration by importing this file. */ $config = new PhpCsFixer\Config(); return $config ->setRules([ 'blank_line_after_namespace' => true, 'fully_qualified_strict_types' => true, 'global_namespace_import' => true, 'no_empty_phpdoc' => true, 'no_leading_import_slash' => true, 'no_superfluous_phpdoc_tags' => true, 'no_unused_imports' => true, 'ordered_imports' => true, 'phpdoc_align' => true, 'phpdoc_indent' => true, 'phpdoc_order' => true, 'phpdoc_return_self_reference' => true, 'phpdoc_scalar' => true, 'phpdoc_separation' => true, 'phpdoc_single_line_var_spacing' => true, 'phpdoc_trim' => true, 'phpdoc_trim_consecutive_blank_line_separation' => true, 'phpdoc_types_order' => true, 'phpdoc_var_annotation_correct_order' => true, 'single_blank_line_before_namespace' => true, 'single_import_per_statement' => true, 'single_line_after_imports' => true, ]) ->setFinder(PhpCsFixer\Finder::create() ->exclude('vendor') ->in(__DIR__) ) ;
| @@ -117,49 +128,49 @@ class Engine | |||
| /** | |||
| * The used code node builder. | |||
| * | |||
| * @var PHPBuilder<\PDepend\Source\AST\ASTNamespace>|null | |||
| * @var null|PHPBuilder<ASTNamespace> | |||
There was a problem hiding this comment.
Suggested change
| * @var null|PHPBuilder<ASTNamespace> | |
| * @var PHPBuilder<ASTNamespace>|null |
I would keep the order with null always at the end.
There was a problem hiding this comment.
Ok, I can do that as a fullow up once this is merged.
kylekatarnls
approved these changes
Jan 30, 2022
This was referenced Apr 25, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: documentation update
Breaking change: no
Apply the same rules for code style in PHPDoc as for native code
A large par of the changes where done using php-cs-fixer (see commit description for the settings that where used)
I have verified the changes with PHPStan at level 2