Run PHPStan in CI #1017
Merged
Run PHPStan in CI #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In docblocks and exceptions FQCN should be used. /** @var \PHPMD\RuleViolation $violation */ |
|
I'm not sure how this is relevant for this PR, but for PDepend we actually settled on importing the classes rather then using FQN, see pdepend/pdepend#587 I expect the same to hold true here. |
|
All right, all right. |
|
Here is a breakdown of how many issues are left at each level of PHPStan: 2: 61 All in all very few issues. |
tvbeek
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied from PDepend with a few adjustments for dependencies