GHA: upload codecov in a dedicated job

Uploading from multiple jobs cause races
pdfarranger · Nov 4, 2023 · 3c50e9b · 3c50e9b
1 parent 1f87536
commit 3c50e9b
Showing 1 changed file with 30 additions and 16 deletions.
diff --git a/.github/workflows/install.yml b/.github/workflows/install.yml
@@ -26,10 +26,10 @@ jobs:
       run: python3 -m coverage run --data-file=.coverage.exporter -m unittest -v -f tests.test_exporter
     - name: Core Tests and Coverage
       run: python3 -m coverage run --data-file=.coverage.core -m unittest -v -f tests.test_core
-    - name: Combine Coverage
-      run: python3 -m coverage combine
-    - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3
+    - uses: actions/upload-artifact@v3
+      with:
+        name: coverage
+        path: .coverage.*
   build-pikepdf-4:
     runs-on: ubuntu-latest
     # PikePDF 4.4.1
@@ -47,13 +47,13 @@ jobs:
     - name: Dogtail Tests and Coverage
       run: python3 -X tracemalloc -u -m unittest -v -f tests.test
     - name: Exporter Tests and Coverage
-      run: python3 -m coverage run --data-file=.coverage.exporter -m unittest -v -f tests.test_exporter
+      run: python3 -m coverage run --data-file=.coverage.exporter.pp4 -m unittest -v -f tests.test_exporter
     - name: Core Tests and Coverage
-      run: python3 -m coverage run --data-file=.coverage.core -m unittest -v -f tests.test_core
-    - name: Combine Coverage
-      run: python3 -m coverage combine
-    - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3
+      run: python3 -m coverage run --data-file=.coverage.core.pp4 -m unittest -v -f tests.test_core
+    - uses: actions/upload-artifact@v3
+      with:
+        name: pp4-coverage
+        path: .coverage.*
   build-pikepdf-6:
     runs-on: ubuntu-latest
     # PikePDF 6.0.1
@@ -67,13 +67,27 @@ jobs:
     - name: Dogtail Tests and Coverage
       run: python3 -X tracemalloc -u -m unittest -v -f tests.test
     - name: Exporter Tests and Coverage
-      run: python3 -m coverage run --data-file=.coverage.exporter -m unittest -v -f tests.test_exporter
+      run: python3 -m coverage run --data-file=.coverage.exporter.pp6 -m unittest -v -f tests.test_exporter
     - name: Core Tests and Coverage
-      run: python3 -m coverage run --data-file=.coverage.core -m unittest -v -f tests.test_core
-    - name: Combine Coverage
-      run: python3 -m coverage combine
-    - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3
+      run: python3 -m coverage run --data-file=.coverage.core.pp6 -m unittest -v -f tests.test_core
+    - uses: actions/upload-artifact@v3
+      with:
+        name: pp6-coverage
+        path: .coverage.*
+  upload-to-codecov:
+    needs: [build, build-pikepdf-4, build-pikepdf-6]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Download Artifacts
+        uses: actions/download-artifact@v3
+      - name: Install Coverage
+        run: pip3 install coverage
+      - name: Combine Coverage
+        run: python3 -m coverage combine
+      - name: Upload to Codecov
+        uses: codecov/codecov-action@v3
   build-pikepdf-1:
     runs-on: ubuntu-latest
     # PikePDF 1.19