Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIME: allow PDF Arranger to be recognised as a handler for all types of file that it can handle #390

Closed
grahamperrin opened this issue Jan 15, 2021 · 4 comments · Fixed by #413
Labels
low priority Stuff I don't want for the next release
Milestone

Comments

@grahamperrin
Copy link

Building upon #202

Enhancement request

Please make the application recognisable for the purpose of opening PNG, JPEG and other types of file that it can handle.

Workarounds

With KDE Plasma 5 (on FreeBSD-CURRENT) I can remember an association, for example:

2021-01-15 05:14:46

– however (unless I'm missing something) the remembrance can not be made without also setting the app as a default.

So each such remembered association must be followed by demoting PDF Arranger, or (as shown below) promoting what was previously my preferred application:

2021-01-15 05:19:03

@dreua
Copy link
Member

dreua commented Jan 15, 2021

I previously thought about this and wasn't sure we should do it since pdfarranger is not really a good program to open images in general, it's useful only for the special task of creating PDFs from images. On the other hand I don't see a big argument against it and since it is now requested we can just do it. Any thoughts from the other maintainers?

The implementation should be easily done by adding the correct mime-types in the desktop file. (PNG, JPEG/JPG, anything else?)

@grahamperrin Just to double-check, can you quickly confirm that this is only about the images and pdfarranger appears for opening PDFs by default (like it should)?

@grahamperrin

This comment has been minimized.

@dreua
Copy link
Member

dreua commented Jan 16, 2021

@grahamperrin Let's try to stay on topic and with reproducible issues here, I'll hide your last comments since it's not adding value to this and the linked issue in my opinion. (You may open a new issue once you have verified it's reproducible and you still think it is important to get it fixed. Fwiw I quickly gave it a try and could not reproduce it in my system.)

@dreua
Copy link
Member

dreua commented Jan 16, 2021

For reference on MIME types here are excerpts from desktop files on my system:

Gimp:
MimeType=image/bmp;image/g3fax;image/gif;image/x-fits;image/x-pcx;image/x-portable-anymap;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-psd;image/x-sgi;image/x-tga;image/x-xbitmap;image/x-xwindowdump;image/x-xcf;image/x-compressed-xcf;image/x-gimp-gbr;image/x-gimp-pat;image/x-gimp-gih;image/tiff;image/jpeg;image/x-psp;application/postscript;image/png;image/x-icon;image/x-xpixmap;image/x-exr;image/webp;image/x-webp;image/svg+xml;application/pdf;image/x-wmf;image/jp2;image/x-xcursor;

Excerpt from Evince:
application/pdf;application/x-bzpdf;application/x-ext-pdf;application/x-gzpdf;application/x-xzpdf;
Note the x-ext-pdf; maybe we should add this. I couldn't really find a definition for the x-ext types but it surely sounds like a catch all for files with pdf extentsion.

eog aka "eye of gnome" aka "The Gnome image viewer":
MimeType=image/bmp;image/gif;image/jpeg;image/jpg;image/pjpeg;image/png;image/tiff;image/x-bmp;image/x-gray;image/x-icb;image/x-ico;image/x-png;image/x-portable-anymap;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-xbitmap;image/x-xpixmap;image/x-pcx;image/svg+xml;image/svg+xml-compressed;image/vnd.wap.wbmp;image/x-icns;

img2pdf's test files suggest it supports png, gif, tif and jpg extensions, while the source code lists even more:
*.bmp *.eps *.gif *.ico *.jpeg *.jpg *.jp2 *.pcx *.png *.ppm *.tiff

Getting this 100% right may be hard but we can probably do with a good estimate.

@jeromerobert jeromerobert added the low priority Stuff I don't want for the next release label Jan 16, 2021
dreua added a commit to dreua/pdfarranger that referenced this issue Feb 7, 2021
dreua added a commit to dreua/pdfarranger that referenced this issue Feb 7, 2021
dreua added a commit to dreua/pdfarranger that referenced this issue Feb 7, 2021
jeromerobert pushed a commit that referenced this issue Feb 11, 2021
@jeromerobert jeromerobert added this to the 1.7.1 milestone Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Stuff I don't want for the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants