Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl + drag & drop create referenced pages (operation done to one page will be applied to other pages) #410

Closed
kbengs opened this issue Feb 6, 2021 · 2 comments · Fixed by #411
Closed

Ctrl + drag & drop create referenced pages (operation done to one page will be applied to other pages) #410

kbengs opened this issue Feb 6, 2021 · 2 comments · Fixed by #411
Milestone
1.7.1

Comments

@kbengs
Copy link
Member

kbengs commented Feb 6, 2021

Found a interresting bug. To reproduxe:

  • Drag & drop a page while ctrl is pressed -> page will be copied to new location
  • Rotate one of theese two pages -> the other page will be rotated also

Actually all operations done to one of the pages will be applied to all other pages that are created with ctrl + drag & drop.

Could of course be a feature. But I think it is unexpected.
@angsch
Copy link
Member

angsch commented Feb 6, 2021

I did a small mistake when I tried this out and got another strange behavior:

  • Drag & drop a page while ctrl is pressed -> Now two pages are selected.
  • Rotate once while having both pages selected ->Both pages are rotated by 180°.

@kbengs
Copy link
Member Author

kbengs commented Feb 6, 2021

did a small mistake when I tried this out and got another strange behavior:

I guess what is happening here is that first the first page is rotated 90 degrees, but the second page is referenced, so it will be rotated also. Then it rotates the second page 90 degrees, and as the first page is referenced it will be rotated also. So result is a 180 degree rotation.

kbengs added a commit to kbengs/pdfarranger that referenced this issue Feb 6, 2021
@kbengs
Fix issue with pages copied with ctrl + dnd
db3f1cc 
Ctrl + drag & drop creates referenced pages. Operations (e.g. rotate)
done to a referenced page will be applied to all pages it reference to.
That is not what we want. All pages should be "real" copies.
Fix pdfarranger#410
@kbengs kbengs mentioned this issue Feb 6, 2021
Merged
@jeromerobert jeromerobert added this to the 1.7.1 milestone Feb 6, 2021
jeromerobert pushed a commit that referenced this issue Feb 6, 2021
@kbengs @jeromerobert
Fix issue with pages copied with ctrl + dnd
c21f2de 
Ctrl + drag & drop creates referenced pages. Operations (e.g. rotate)
done to a referenced page will be applied to all pages it reference to.
That is not what we want. All pages should be "real" copies.
Fix #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

Fix issue with pages copied with ctrl + dnd kbengs/pdfarranger
3 participants
@jeromerobert @angsch @kbengs