Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI look & feel (header bar, symbolic icons) #87

Closed
jeromerobert opened this issue Jun 25, 2019 · 7 comments
Closed

New UI look & feel (header bar, symbolic icons) #87

jeromerobert opened this issue Jun 25, 2019 · 7 comments
Milestone

Comments

@jeromerobert
Copy link
Member

GtkImageMenuItem is deprecated. It should be replaced by GMenu. This is needed for GTK4 migration (which is not an emergency).

Removing GtkImageMenuItem mean removing stock items which mean that many menu items won't be translated by GTK anymore. So all .po files needs to be updated.

@jeromerobert
Copy link
Member Author

jeromerobert commented Jun 26, 2019

@jeromerobert
Copy link
Member Author

I was already not fond of removing icons from menus but looking at other GTK applications I think I have to go even further. Even Meld has already redesigned its GUI so it now looks like evince, gedit and many other gnome/GTK apps. I personally don't like such look & feel but this is mostly subjective and resistance against Gnome/GTK guidelines is futile. So here is the roadmap:

  • Replace the menu bar by a GtkHeaderBar
  • Merge all menus in a single one located on the left of the header bar. This new menu will be a GMenu.
  • Replace all icons by their symbolic version
  • Move toolbar buttons to the new header bar

@jeromerobert jeromerobert changed the title Replace GtkImageMenuItem by GMenu New UI look & feel (header bar, symbolic icons) Jun 29, 2019
@jeromerobert jeromerobert added the low priority Stuff I don't want for the next release label Jun 30, 2019
@onny
Copy link

onny commented Nov 22, 2019

Just as a reference how nice this could look:

image
(see https://github.com/onny/pdfmod3)

@Amr-Ibra
Copy link

Amr-Ibra commented Jan 5, 2020

An easy start is to just replace the icons to their symbolic versions. The legacy full-coloured icons don't scale well in Hi DPI displays.

@jeromerobert jeromerobert removed the low priority Stuff I don't want for the next release label Feb 2, 2020
@jeromerobert jeromerobert added this to the 1.5 milestone Feb 3, 2020
@jeromerobert
Copy link
Member Author

pdfarranger-newlook
I moved the toolbar button to the header bar (in a dirty dev branch). I was thinking of creating a single main menu but now I'm thinking we have too many actions for that. I will probably create 2:

  • a main menu which will receive file, view and help menus
  • an edit menu (same as the current one)

What's your opinion ? Does it feel "gnomish" or should I have less menus or icons in the header bar ?

@onny
Copy link

onny commented Mar 22, 2020

Wow thanks for this nice concept :) I was already checking today for some updates on this ;)
This is was evince is doing:

2020-03-22-202438_grim

Show edit menu:

2020-03-22-202453_grim

Personally I prefer gedit which is even simpler and cleaner:

2020-03-22-202731_grim

But this might not fit the need in this case. At least the bold open and save option is really good here in my opinion.

@kbengs
Copy link
Member

kbengs commented Mar 25, 2020

I think that looks nice. Also a display for total number of pages would be good to have IMO. Would it have room somewhere? It would help user to see if things are going as planned. (if adding pages -> number increase..)

jeromerobert added a commit that referenced this issue Mar 29, 2020
* No longer use deprecated widgets like GtkImageMenuItem which won't be in GTK4
* Close #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants