Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a "raise KeyError(key) from None" in pikepdf #1022

Merged
merged 1 commit into from Dec 29, 2023
Merged

Fix a "raise KeyError(key) from None" in pikepdf #1022

merged 1 commit into from Dec 29, 2023

Conversation

jeromerobert
Copy link
Member

* At pikepdf/models/metadata.py:706
* Close #1019
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (80dc4b0) 80.27% compared to head (b5500aa) 80.20%.
Report is 1 commits behind head on main.

Files Patch % Lines
pdfarranger/metadata.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   80.27%   80.20%   -0.08%     
==========================================
  Files          13       13              
  Lines        4898     4900       +2     
==========================================
- Hits         3932     3930       -2     
- Misses        966      970       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dreua dreua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreua dreua merged commit cfb433e into main Dec 29, 2023
10 of 11 checks passed
@dreua dreua deleted the bug1019 branch December 29, 2023 14:04
@kbengs kbengs added this to the 1.11 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Save PDF with Edits
3 participants