Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it run on windows (msys2/mingw64) #16

Closed
wants to merge 5 commits into from

Conversation

carlos22
Copy link
Contributor

@carlos22 carlos22 commented Nov 2, 2018

Some modifications to make it work on msys2 (tested with mingw64, should work with mingw32).
Some discussion about a windows version: see issue #11

Known Problems / TODOs

  • fix translations (only english currently)
  • fix delete of temp files on exit (there is some code in the old win version)
  • fix about dialog (argv0 is python3w in some cases)

@jeromerobert
Copy link
Member

@carlos22 I was not able to reproduce the error you talk about in 8286d17

Could you confirm that

--- a/pdfshuffler/pdfshuffler.py
+++ b/pdfshuffler/pdfshuffler.py
@@ -276,7 +276,7 @@ class PdfShuffler:
         self.reverse_order_app_menu_item = self.uiXML.get_object('imagemenuitem_reverse_order')
 
         # Initializing variables
-        self.export_directory = os.getenv('HOME')
+        self.export_directory = os.path.expanduser('~')
         self.import_directory = self.export_directory
         self.nfile = 0
         self.iv_auto_scroll_direction = 0

fix it ?

@jeromerobert
Copy link
Member

Closing. Only localization remains so the story will continue at in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants