-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #240 #260
Resolves #240 #260
Conversation
@angsch I'm nearly sure you are already addressed this, but since I'm not programmer I give this note to avoid post implementation fix .... Best regards. |
Some observations when I tested it:
But overall I think it looks good. |
@kbengs |
Thank you @angsch. You PR looks good. Here is what I would add to kbengs comments:
|
* Extend export modes to a total of 4. 1) standard save mode, 2) export all pages to individual files, 3) selection to a single PDF, 4) selection to individual files * Add 'Export special' option to user inteface, offering 'export all pages to individual pages' and 'export selection to individual pages'
The code has been revised according to your comments. I think it is ready for being merged. |
Two small things I still notice:
|
CTRL+F is usually shortcut for find, maybe something else should be used here? |
I merge it, we'll fix that kind of details. |
Add two more export options, 'export selection to individual files' requested in #240 and 'export all pages to individual files'.