Enable autoscroll when rubberband selecting #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoscroll the view when mouse cursor goes near or outside upper/lower
window edges when rubberband selecting
Iconview actually has built in autoscroll for dnd, rubberband selecting and when navigating with keyboard arrows. It can be enabled with:
-self.sw.add_with_viewport(self.iconview)
+self.sw.add(self.iconview)
(some other small changes are also needed)
The problem is that it wouldn't be possible to have the hack that makes it possible to start a rubberband selection from left margin. (end of on_window_size_request method) And also autoscroll when dnd don't work any more since we have "return True" in iv_dnd_motion metod.
Another positive effect of it would be that iconview height allocation is working correctly..
But because that has negative effects I think this commit is the best way now.