Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autoscroll when rubberband selecting #266

Merged
merged 1 commit into from Aug 22, 2020

Conversation

kbengs
Copy link
Member

@kbengs kbengs commented Aug 21, 2020

Autoscroll the view when mouse cursor goes near or outside upper/lower
window edges when rubberband selecting

Iconview actually has built in autoscroll for dnd, rubberband selecting and when navigating with keyboard arrows. It can be enabled with:
-self.sw.add_with_viewport(self.iconview)
+self.sw.add(self.iconview)
(some other small changes are also needed)

The problem is that it wouldn't be possible to have the hack that makes it possible to start a rubberband selection from left margin. (end of on_window_size_request method) And also autoscroll when dnd don't work any more since we have "return True" in iv_dnd_motion metod.
Another positive effect of it would be that iconview height allocation is working correctly..

But because that has negative effects I think this commit is the best way now.

Autoscroll the view when mouse cursor goes near or outside upper/lower
window edges when rubberband selecting
@jeromerobert jeromerobert added this to the 1.7.0 milestone Aug 22, 2020
@jeromerobert jeromerobert merged commit 9ed3821 into pdfarranger:master Aug 22, 2020
@kbengs kbengs deleted the RubberbandAutoscroll branch September 25, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants