Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OK button in metadata dialog #511

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

angsch
Copy link
Member

@angsch angsch commented Jul 18, 2021

dialog.set_default_response(Gtk.ResponseType.OK) does not have an effect because TreeView gets the focus. Manually set the focus so that pressing enter defaults to the OK button.

Set the focus onto the OK button. On pressing
enter, the OK button is now triggered.
@codecov-commenter
Copy link

Codecov Report

Merging #511 (f31a5dd) into main (0726fc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   73.11%   73.12%           
=======================================
  Files          10       10           
  Lines        2875     2876    +1     
=======================================
+ Hits         2102     2103    +1     
  Misses        773      773           
Impacted Files Coverage Δ
pdfarranger/metadata.py 83.60% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0726fc7...f31a5dd. Read the comment docs.

@jeromerobert jeromerobert merged commit 88a1429 into pdfarranger:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants