Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom scale issues #564

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

kbengs
Copy link
Member

@kbengs kbengs commented Nov 1, 2021

Steps to reproduce the issue:

  • Open a PDF and zoom to full page
  • Select all + Cut
  • Paste
    -> The pages will not receive a thumbnail. Thumbnail is rendered but update_thumbnail does not accept the page.

Result was that page did not receive a thumbnail in certain case.
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #564 (5e37030) into main (0f25b5e) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   72.47%   72.49%   +0.01%     
==========================================
  Files          10       10              
  Lines        2936     2934       -2     
==========================================
- Hits         2128     2127       -1     
+ Misses        808      807       -1     
Impacted Files Coverage Δ
pdfarranger/pdfarranger.py 67.33% <60.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90bdc9...5e37030. Read the comment docs.

Caused a cairo.Error: invalid value
@kbengs kbengs changed the title Fix self.zoom_scale and p.zoom missmatch issue Fix zoom scale issues Nov 2, 2021
@kbengs
Copy link
Member Author

kbengs commented Nov 2, 2021

To reproduce second issue:

  • Open a PDF
  • Make window height as small as possible
  • Zoom to full page
  • Select all + cut
  • Paste
    -> cairo.Error: invalid value.

@jeromerobert jeromerobert merged commit f18fd27 into pdfarranger:main Nov 2, 2021
@kbengs kbengs deleted the fix-rendering-issue branch November 27, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants