Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a zoom fit by double-click issue #670

Merged
merged 1 commit into from May 15, 2022

Conversation

kbengs
Copy link
Member

@kbengs kbengs commented May 14, 2022

This issue was caused by 5a5c5a2

When clicking on a page that is zoomed so that it does not fit into
window, the page will jump up/down on every click. Zoom fit by double-
clicking the page does not work then.
@codecov-commenter
Copy link

Codecov Report

Merging #670 (28e9cdd) into main (6c84e0d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   73.29%   73.33%   +0.03%     
==========================================
  Files          10       10              
  Lines        3269     3270       +1     
==========================================
+ Hits         2396     2398       +2     
+ Misses        873      872       -1     
Impacted Files Coverage Δ
pdfarranger/pdfarranger.py 69.21% <100.00%> (+0.01%) ⬆️
pdfarranger/core.py 87.46% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c84e0d...28e9cdd. Read the comment docs.

@jeromerobert jeromerobert merged commit 1895e12 into pdfarranger:main May 15, 2022
@kbengs kbengs deleted the cursor-set-issue branch May 15, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants