Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to modify export counter value #794

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

kbengs
Copy link
Member

@kbengs kbengs commented Jan 1, 2023

self.save_file is used for "save all to single file"
self.export_file is used for all other "exportmodes"

@petaflot would you like to test this before merge?

If user modify the value in "filename-001.pdf" in the export dialog it
will be remembered so that on next export +1 is added to the value.
Close pdfarranger#782
@codecov-commenter
Copy link

Codecov Report

Base: 71.77% // Head: 71.80% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8cee08e) compared to base (46a4364).
Patch coverage: 82.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   71.77%   71.80%   +0.03%     
==========================================
  Files          10       10              
  Lines        3479     3494      +15     
==========================================
+ Hits         2497     2509      +12     
- Misses        982      985       +3     
Impacted Files Coverage Δ
pdfarranger/pdfarranger.py 68.66% <82.92%> (+0.15%) ⬆️
pdfarranger/core.py 86.63% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@petaflot
Copy link

petaflot commented Jan 7, 2023

probably didn't test it the way I was supposed to (patched manually), but from what I've seen it works fine.

suggestion : IMHO it would be nice that "ctrl+shift+e" should export+save+delete selection. any thoughts?

@kbengs
Copy link
Member Author

kbengs commented Jan 8, 2023

Thanks for testing. Not sure about "export+save+delete" But if it's done well and documented maybe it could be merged. "ctrl+shift+e" is already used though.

@jeromerobert jeromerobert merged commit 3b3d1da into pdfarranger:main Jan 14, 2023
@kbengs kbengs deleted the 782 branch January 23, 2023 15:31
@jeromerobert jeromerobert added this to the 1.10 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants