Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes related to #849 #852

Merged
merged 3 commits into from Apr 23, 2023

Conversation

kbengs
Copy link
Member

@kbengs kbengs commented Apr 22, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (fd64de6) 67.67% compared to head (4f7fd1a) 67.52%.

❗ Current head 4f7fd1a differs from pull request most recent head c7a4996. Consider uploading reports for the commit c7a4996 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   67.67%   67.52%   -0.15%     
==========================================
  Files          10       10              
  Lines        3913     3920       +7     
==========================================
- Hits         2648     2647       -1     
- Misses       1265     1273       +8     
Impacted Files Coverage Δ
pdfarranger/config.py 63.21% <0.00%> (-2.26%) ⬇️
pdfarranger/pdfarranger.py 66.25% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbengs
Copy link
Member Author

kbengs commented Apr 22, 2023

My Windows 7 install will start pdfarranger in Swedish by default although Windows is in English. This change seems to fix that. If I change Windows language (in Windows 10) it will also change in pdfarranger. This issue has been reported in #578 and #849 (I think)

@kbengs kbengs marked this pull request as ready for review April 22, 2023 13:07
@jeromerobert jeromerobert merged commit 7ddcfa3 into pdfarranger:main Apr 23, 2023
8 checks passed
@kbengs kbengs deleted the config-file-location branch April 24, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants