New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Adds Occitan language #856
Conversation
po/oc.po
Outdated
|
||
#: pdfarranger/metadata.py:212 | ||
msgid "Value" | ||
msgstr "Valor " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an extra space: Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups yes typo here!
po/oc.po
Outdated
|
||
#: pdfarranger/pdfarranger.py:946 | ||
msgid "Save changes before closing?" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the following 5 strings are missing translations which might be especially important so people can make the right decisions and not lose work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will make a more complete PR later then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally just add commits to this PR i.e. to your main branch. Thanks!
There are some strings missing, some less some more important, see my comment above. I guess there is no harm in merging it. Its probably better than having no translation at all and falling back to English. |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 10 10
Lines 4053 4053
=======================================
Hits 2656 2656
Misses 1397 1397 ☔ View full report in Codecov by Sentry. |
Mercés |
Hello!
My small contribution.