Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Adds Occitan language #856

Merged
merged 1 commit into from Apr 29, 2023
Merged

i18n: Adds Occitan language #856

merged 1 commit into from Apr 29, 2023

Conversation

Mejans
Copy link
Contributor

@Mejans Mejans commented Apr 27, 2023

Hello!
My small contribution.

po/oc.po Outdated

#: pdfarranger/metadata.py:212
msgid "Value"
msgstr "Valor "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an extra space: Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups yes typo here!

po/oc.po Outdated

#: pdfarranger/pdfarranger.py:946
msgid "Save changes before closing?"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following 5 strings are missing translations which might be especially important so people can make the right decisions and not lose work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will make a more complete PR later then!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally just add commits to this PR i.e. to your main branch. Thanks!

@dreua
Copy link
Member

dreua commented Apr 28, 2023

Partial translation to start

There are some strings missing, some less some more important, see my comment above.

I guess there is no harm in merging it. Its probably better than having no translation at all and falling back to English.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ddcfa3) 65.53% compared to head (9cb6a44) 65.53%.

❗ Current head 9cb6a44 differs from pull request most recent head 765089a. Consider uploading reports for the commit 765089a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files          10       10           
  Lines        4053     4053           
=======================================
  Hits         2656     2656           
  Misses       1397     1397           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeromerobert jeromerobert merged commit ddcdea1 into pdfarranger:main Apr 29, 2023
8 checks passed
@jeromerobert
Copy link
Member

Mercés

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants