No longer use python-distutils-extra #859
Conversation
jeromerobert
commented
May 6, 2023
jeromerobert
commented
- python-distutils-extra was added by 2077a73
- it relies on intltool which is deprecated as gettext can now do the job alone
- intltool relies on perl which is a tricky dependency on Windows
- PyPA has announced disruptive changes to distutils/setuptools/pip that will propably break python-distutils-extra
- clean_i18n is removed as it was not very useful
- Close Look into replacing python-distutils-extra #853
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
setup.py
Outdated
| @@ -20,9 +20,13 @@ | |||
| # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
| # | |||
|
|
|||
| import setuptools | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
jeromerobert
force-pushed
the
distutilsextra
branch
from
9f0c97b
to
f0c2347
Compare
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
- Coverage 65.55% 65.53% -0.03%
==========================================
Files 10 10
Lines 4053 4053
==========================================
- Hits 2657 2656 -1
- Misses 1396 1397 +1 ☔ View full report in Codecov by Sentry. |
* python-distutils-extra was added by 2077a73 * it relies on intltool which is deprecated as gettext can now do the job alone * intltool relies on perl which is a tricky dependency on Windows * PyPA has announced disruptive changes to distutils/setuptools/pip that will propably break python-distutils-extra * clean_i18n is removed as it was not very useful * Close #853
jeromerobert
force-pushed
the
distutilsextra
branch
from
ee21a65
to
2e886e0
Compare
| build_i18n, clean_i18n, build_extra, build_icons) | ||
| # for the time being do not use setuptools.command because: | ||
| # * setuptools is to old in many distro (ex: Ubuntu 22.04) | ||
| # * The Fedora package relies on wheel so it would not contains translation and |
There was a problem hiding this comment.
Do you want me to look after the Fedora stuff? Pretty sure we can get rid of the wheel. Wheel's not ideal anyway ;) (It was just the easiest back when I first packaged this.)
There was a problem hiding this comment.
You read my mind. Yes !
There was a problem hiding this comment.
Just to be on the same page: The current version still works with the wheel but you want me to get rid of it in order to further improve the thing, correct?
|
I cannot test the Windows installer of this PR for now. I'll do it as soon as I have a Windows box. Please do not merge until Windows installer has been tested. |
|
More discussion: #860 |
|
Test results on Windows 10, msi and zip from https://github.com/pdfarranger/pdfarranger/actions/runs/4903360382?pr=859:
All above is true for both portable zip and installed msi. |
