Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of excessive logging #3

Closed
tadvi opened this issue Sep 25, 2017 · 1 comment
Closed

Get rid of excessive logging #3

tadvi opened this issue Sep 25, 2017 · 1 comment

Comments

@tadvi
Copy link

tadvi commented Sep 25, 2017

Libraries and source code has excessive logging interleaved with code that does main work.
This makes reading source code harder.

Lines like:
logInfoValidate.Println("*** validateShadingDictCommonEntries end ***")

Go standard library should be inspiration for this. It has no excessive logging inside library code.
Please get rid of logging inside the library.

@hhrutter
Copy link
Collaborator

Thanks, I am aware but I still need all of this for debugging. Still at 0.0.x. I will mark the next version as prerelease.

hhrutter pushed a commit that referenced this issue Feb 25, 2024
* booklet covers

* 4up booklet guide cut label

* fix

* add top fold ordering scheme

* dont overwrite PaperSize dimensions if landscape

* top fold for landscape

* cleaner test

* fix for landscape short edge binding

* binding option. fix for covers with funky bindings

* add 6up sequence

* fix

* add border on cropbox

* border on cropbox in correct place

* crop border in right place, border styling

* contact sheet attempt

* Revert "contact sheet attempt"

This reverts commit f2258fc.

* Prefect bound (#2)

* wip

* horizontal page handling flip

* name

* fix less common 4up layouts

* fix less common 4up layouts

* uncomment tests

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants