Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alpha masks in CMYK, Greyscale #483

Conversation

scoiatael
Copy link

Hey,

First of all, thanks for a great library - at OpenDesign we started using it to extract data from Adobe Illustrator files :) Hope to bring more contributions in the future.

About this PR - looks like alpha masks are used extensively in these kinds of files. so I added simple support for them. Unfortunately the code as it is converts everything into NRGBA - meaning we might lose some colour/format specific info - but I don't know these formats well enough.

Let me know if and how I should fix it and I'll be happy to do so :)

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

@hhrutter
Copy link
Collaborator

Thanks for taking the time!
Please provide a small sample image for each new image type you provide support with this PR.
I'd like to add corresponding tests.

@hhrutter hhrutter self-assigned this Jun 10, 2022
@scoiatael
Copy link
Author

Sure - let me circle back in around a week, since the files I've been testing on are proprietary and I'll need to handcraft something in Illustrator :)

@scoiatael
Copy link
Author

Added sample file and test for CMYK softmasks -> file is taken from here: https://365psd.com/vector/red-eaten-apple-by-ray-craighead-27023 - turned out to be easier to just find one than create it by hand.
Sadly can't find anything to test DeviceGray with.

@hhrutter
Copy link
Collaborator

Thanks! I'll check it out.

@hhrutter hhrutter force-pushed the master branch 3 times, most recently from 92c981a to 25f7cef Compare March 3, 2023 00:21
@hhrutter
Copy link
Collaborator

hhrutter commented Mar 3, 2023

Hello,
Unfortunately the timing was not right for a merge in when you initially opened this PR - sorry..
Please get the latest release and ensure all tests pass, then I am happy to merge in your contribution.
Thank you!

@hhrutter hhrutter closed this in add1372 May 6, 2023
@hhrutter
Copy link
Collaborator

hhrutter commented May 7, 2023

This is merged into the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants