Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of stamps/watermarks loaded into memory #732

Closed
wants to merge 1 commit into from

Conversation

vsenko
Copy link

@vsenko vsenko commented Nov 8, 2023

Use stamps/watermarks loaded into memory

Currently it is possible to load PDF stamps/watermarks only from files. In some cases it would be convenient to use already loaded into memory files (similar was discussed in #472).

This PR proposes to extend the Watermark model with additional filed PDF which can be used to provide an already loaded PDF stamp/watermark as a io.ReadSeeker.

The corresponding code to load it in createPDFResForWM is also provided.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@hhrutter
Copy link
Collaborator

hhrutter commented Nov 13, 2023

Makes sense.
Let me see how we can fit this into the current API.

What API call are you using?

@vsenko
Copy link
Author

vsenko commented Nov 13, 2023

I'm using AddWatermarks from api, the actual code is here: https://github.com/sigex-kz/ddc/blob/e5e0816115a33f55720ca3be08ea3f34fc37d06b/ddc.go#L467

@hhrutter hhrutter closed this in 297212b Dec 9, 2023
@hhrutter
Copy link
Collaborator

Thank you for your time and efforts!
This is part of https://github.com/pdfcpu/pdfcpu/releases/tag/v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants