New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copying from "bytes.Buffer" to get underlying bytes. #811

Merged

hhrutter merged 1 commit into pdfcpu:master from fancycode:dont-copy-bytes-buffer

Feb 29, 2024

Contributor

fancycode commented Feb 28, 2024

As described in #810, this PR removes the unnecessary copying from bytes.Buffer to get the []byte data where possible.

Fixes #810


          Avoid copying from "bytes.Buffer" to get underlying bytes.

95c2d64

hhrutter added a commit that referenced this pull request


          Merge PR #811

268e6bb

hhrutter merged commit 95c2d64 into pdfcpu:master

12 of 15 checks passed

Collaborator

hhrutter commented Mar 1, 2024

Thanks again! Good catch 👍🏻

fancycode deleted the dont-copy-bytes-buffer branch

March 18, 2024 08:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment