Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing RecurringJob #43

Merged
merged 13 commits into from
Oct 1, 2018
Merged

Introducing RecurringJob #43

merged 13 commits into from
Oct 1, 2018

Conversation

sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented Sep 30, 2018

  • Moved Qless\Jobs\Job => Qless\Jobs\BaseJob
  • Introducing Qless\Jobs\RecurringJob

@sergeyklay sergeyklay added the wip Work in progress label Sep 30, 2018
@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #43 into master will increase coverage by 6.57%.
The diff coverage is 96.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     55.69%   62.27%   +6.57%     
- Complexity      423      483      +60     
============================================
  Files            29       31       +2     
  Lines          1142     1251     +109     
============================================
+ Hits            636      779     +143     
+ Misses          506      472      -34
Impacted Files Coverage Δ Complexity Δ
src/Client.php 100% <ø> (ø) 14 <0> (ø) ⬇️
src/Workers/ForkingWorker.php 1% <0%> (ø) 85 <5> (ø) ⬇️
src/Redis.php 97.01% <100%> (+0.13%) 22 <0> (ø) ⬇️
src/Jobs/Reservers/RoundRobinReserver.php 100% <100%> (ø) 7 <4> (ø) ⬇️
src/Jobs/AbstractJob.php 100% <100%> (ø) 20 <20> (?)
src/Jobs/Reservers/OrderedReserver.php 100% <100%> (ø) 4 <4> (ø) ⬇️
src/Queues/Queue.php 77.67% <100%> (+17.85%) 60 <0> (+13) ⬆️
src/Jobs/BaseJob.php 95.41% <100%> (ø) 41 <10> (?)
src/Jobs/RecurringJob.php 100% <100%> (ø) 34 <34> (?)
src/Workers/AbstractWorker.php 39.39% <50%> (ø) 23 <3> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8581fd3...fef9b77. Read the comment docs.

@sergeyklay sergeyklay changed the title [WIP]: Introducing RecurringJob Introducing RecurringJob Oct 1, 2018
@sergeyklay sergeyklay removed the wip Work in progress label Oct 1, 2018
@sergeyklay sergeyklay merged commit 73d8267 into master Oct 1, 2018
@sergeyklay sergeyklay deleted the feature/recurring-job branch October 1, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants