Allow missing assets #188

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

@dnagir

This PR removes the inconsistency between Linux and OSX versions of wkhtmltopdf.

When there are missing assets (images, JS etc):

  • on Linux (x64): wkhtmltopdf exits with status code = 2 and does produce actual PDF (but an error is raised)
  • on OSX: wkhtmltopdf exits with status code = 0 and does produce actual PDF (and no error is raised)

This also means that no failures will occur during local development on OSX, but it is more likely to fail in production.

The spec here may need a bit of adjustment depending on what platform it is being run on, but should be a good starting point.

(This also incorporates the #187)

@sigmavirus24
pdfkit member

Could you address the test failures (preferably by not modifying the tests themselves) on Travis?

@sigmavirus24 sigmavirus24 referenced this pull request Aug 15, 2013
Closed

Exitstatus #187

@dnagir

There are a few problems with the tests that I would prefer someone else to look at. A lot of the tests are failing on Travis even prior to this PR (but passing locally on OSX) so I was concentrating on the only 2 in PR.

The original description isn't accurate now after I updated to the recent wkhtmltopdf-binary gem.
Now the given spec fails with status code=1 on OSX but succeeds on Linux (status code = 0).

So it looks like there are also some differences between versions of the wkhtmltopdf as well as platform.

Not sure how to deal with it now? Maybe just using the ignore-load-errors flag should do the job.
Looks like it would be PITA to deal with all those version/platform issues as part of pdfkit.

Opinions?

(BTW, the #187 can be merged separately)

@sigmavirus24
pdfkit member

@dnagir I think we're finally on our way towards having Travis successfully run tests. Could you just rebase this branch against master so we can see if the tests pass on Travis? Thanks!

@sigmavirus24
pdfkit member

@dnagir do you have the chance to rebase this PR?

@sealink sealink referenced this pull request Nov 28, 2013
Merged

Allow missing assets #209

@sigmavirus24
pdfkit member

Closed since #209 ostensibly handles the same issue.

@sigmavirus24 sigmavirus24 reopened this Nov 29, 2013
@sigmavirus24
pdfkit member

Actually looking at the diffs, #209 and this are different enough

@marcus

I'm seeing the opposite behavior, with PDFKit 0.6.1 on OSX with missing images it fails with:

  • Exit with code 2 due to http error: 404 Page not found

If I revert to PDFkit 5.x it generates the pdf with broken images as expected.

@sigmavirus24
pdfkit member

@dnagir could you rebase this pull request?

@dnagir

@sigmavirus24 I'm not sure if I should do this. I'm out of touch with this PR now and don't remember particulars already. People also reported the opposite behaviour to this PR, such as #209.
So maybe it would be better to look there?

@sigmavirus24
pdfkit member

Ok @dnagir. Sorry this sat so long without a good response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment