Separating Schema label from code identifier #304
Conversation
hand-dot
changed the title
hand-dot
changed the title
| @@ -219,7 +219,7 @@ describe('checkPlugins test', () => { | |||
| pdf: async () => {}, | |||
| ui: async () => {}, | |||
| propPanel: { | |||
| propPanelSchema: {}, | |||
| schema: {}, | |||
There was a problem hiding this comment.
This fix is not directly related to this PR.
|
|
||
| const pluginsSchemaTypes = Object.keys(plugins); |
There was a problem hiding this comment.
Stopped using the 'plugins' key.
| @@ -62,7 +55,9 @@ const generate = async (props: GenerateProps) => { | |||
| continue; | |||
| } | |||
|
|
|||
| const render = rendererRegistry[schema.type]; | |||
| const render = Object.values(plugins).find( | |||
| (plugin) => plugin.propPanel.defaultSchema.type === schema.type | |||
There was a problem hiding this comment.
There may be users who are only using the generator, but accessing plugin.propPanel.defaultSchema.type feels a bit awkward. Should it be accessible through plugin.type instead?
There was a problem hiding this comment.
I might be overthinking this. If it doesn't feel awkward as is, I'd like to keep it that way.
There was a problem hiding this comment.
plugin.type would be syntactically cleaner, but plugin.propPanel.defaultSchema.type is not a problem to use 👍
| @@ -1,11 +1,3 @@ | |||
| import type { Schema, PDFRenderProps } from '@pdfme/common'; | |||
There was a problem hiding this comment.
We just use plugin.
This was a welcome side effect.
Thank you for making this proposal.
| @@ -62,7 +55,9 @@ const generate = async (props: GenerateProps) => { | |||
| continue; | |||
| } | |||
|
|
|||
| const render = rendererRegistry[schema.type]; | |||
| const render = Object.values(plugins).find( | |||
| (plugin) => plugin.propPanel.defaultSchema.type === schema.type | |||
There was a problem hiding this comment.
plugin.type would be syntactically cleaner, but plugin.propPanel.defaultSchema.type is not a problem to use 👍
ref: #303