-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ellipse and Rectangle Schema #375
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…e-and-rectangle-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main part of this PR is...
@peteward can you check this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool.
Question - if you want to write a custom plugin that extends one that already exists, is it harder with this change to consolidate the separate files into a single Plugin
definition?
For example, if I want to have another shape plugin and I want to use the same propPanel as your shape
one, is it still easy to do this without duplicating the code?
we can extend like this. const yourShape = {
ui: () => {},
pdf: () => {},
propPanel: {
...ellipse.propPanel,
defaultSchema: {
...ellipse.propPanel.defaultSchema,
type: 'yourShape',
},
},
}; |
ref: