Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX for adding an image #380

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

peteward
Copy link
Collaborator

@peteward peteward commented Dec 18, 2023

fixes #378

Make sure the default sample data is not mistaken for a real image in the UX, when you click you should see the form to choose a proper image.

BEFORE:

Screen.Recording.2023-12-18.at.14.56.30.mov

AFTER:

Screen.Recording.2023-12-18.at.14.52.20.mov

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pdfme-playground ⬜️ Ignored (Inspect) Dec 18, 2023 2:59pm

Copy link
Collaborator

@hand-dot hand-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX

@peteward peteward merged commit d7f606d into main Dec 18, 2023
3 checks passed
hand-dot added a commit that referenced this pull request Dec 19, 2023
hand-dot added a commit that referenced this pull request Dec 19, 2023
* TMP

* TMP

* Stopped inefficient file splitting and bugfix for readonly

* add rectangle schema

* TMP

* TMP

* move some files and i18n

* Add shapes template to generator

* Bugfix

* Import Improve the UX for adding an image #380
@hand-dot hand-dot deleted the pw-better-image-adding-ux branch December 27, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an image is confusing that you need to clear the placeholder
2 participants