Support both libsoup-2.4 and 3.0 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current CI/CD does not catch this since ubuntu/windows use v2. To avoid possible compilation errors (maybe to changed symbols) it would be best to have that in the build process too. But there is an ubuntu package for v3 (see https://packages.ubuntu.com/kinetic/libsoup-3.0-dev). Do you think a "build-libsoup-v3" step is a good option to handle this? |
|
I believe the recommended approach is to use matrix builds, e.g., https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-single-dimension-matrix . But in any case, first this PR should be merged, otherwise all CI builds will fail. Kind of a chicken and egg problem :). |
AndreasBilke
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.