Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CI runs for libsoup v2 and v3 #667

Closed
wants to merge 4 commits into from
Closed

WIP: CI runs for libsoup v2 and v3 #667

wants to merge 4 commits into from

Conversation

AndreasBilke
Copy link
Member

No description provided.

@AndreasBilke
Copy link
Member Author

@fnevgeny I did the matrix setup as you proposed. On ubuntu it works without any problems. On windows I get a compilation error for libsoup3.

Do you know if the matrix approach is wrong or if the libsoupv3 version on windows might have problems?

@fnevgeny
Copy link
Member

fnevgeny commented Jan 3, 2023

On Ubuntu, both runs used libsoup-2.4, please see the logs. I'm surprised it worked (in the sense - the matrix build) for Windows. It's another "chicken and egg" problem - you try to apply a change to a CI action, but what should github do - run the CI from the master against the new version or first apply the patch and then run? I guess it works in a random way, kind of a race condition. Maybe there is a smart trick to do it reliably.

Back to the problem, it seems the two VAPI's (2.4 and 3.0) conflict. 2.4 is anyway included as a dependence of webkit2gtk-4.0. webkit2gtk-4.1 uses libsoup3. Still, the presence of both libsoup-2.4.vapi and libsoup-3.0.vapi in the standard Vala installation is a problem, IMO...

@fnevgeny
Copy link
Member

fnevgeny commented Jan 3, 2023

2.4 is anyway included as a dependence of webkit2gtk-4.0.

Never mind. There is should be no webkit2gtk in the Windows build...

@fnevgeny
Copy link
Member

fnevgeny commented Jan 4, 2023

Well, there are quite a lot of backward-incompatible changes between the 2.4 and 3.0 API's. I was mistaken by the OP's comment in #664. No idea what was meant by "works for me". It certainly couldn't be working. Given the 2.4 version is not deprecated, I'm unwilling to spend time on enabling support of both versions via numerous if/else's.

@fnevgeny
Copy link
Member

fnevgeny commented Jan 4, 2023

I think d1ba29e is worth applying anyway.

@AndreasBilke AndreasBilke deleted the libsoup-ci branch January 5, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants