Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract US map data to separate package #39

Closed
6 tasks done
pdil opened this issue Oct 5, 2020 · 4 comments · Fixed by #49
Closed
6 tasks done

Extract US map data to separate package #39

pdil opened this issue Oct 5, 2020 · 4 comments · Fixed by #49
Assignees
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Milestone

Comments

@pdil
Copy link
Owner

pdil commented Oct 5, 2020

Currently the data frame which contains coordinates to draw the US state and county boundaries is stored within the usmap package. This data should be extracted into a separate package that can be updated independently of usmap. This will greatly reduce the file size of usmap and will make it easier to develop for with the smaller footprint.

It will also prevent the following NOTE that currently appears during R CMD check (notice extdata size compared to installed size):

> checking installed package size ... NOTE
    installed size is  8.4Mb
    sub-directories of 1Mb or more:
      doc       1.6Mb
      extdata   6.4Mb

To do

Extra

  • consider creating more robust script to download shape files from census.gov and automatically create map data frames This would require automated updating of the county-fips or state-fips files and currently there is no easily parseable document providing this information.
@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Oct 5, 2020
@pdil pdil self-assigned this Oct 5, 2020
@pdil
Copy link
Owner Author

pdil commented Oct 9, 2020

Going with usmapdata as the name since it's clear that it's related to usmap.

@pdil
Copy link
Owner Author

pdil commented Oct 9, 2020

Repo created here: https://github.com/pdil/usmapdata

@pdil pdil pinned this issue Oct 9, 2020
@pdil
Copy link
Owner Author

pdil commented Oct 9, 2020

us_map function, data, and tests: pdil/usmapdata@af9c21a

@pdil pdil added this to the v0.6.0 milestone Oct 28, 2020
@pdil
Copy link
Owner Author

pdil commented Feb 7, 2022

Package has been submitted to CRAN, it will appear here when it's published: https://cran.r-project.org/package=usmapdata

@pdil pdil mentioned this issue Feb 9, 2022
4 tasks
@pdil pdil closed this as completed in #49 Feb 11, 2022
@pdil pdil unpinned this issue Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant