Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use usmapdata package #49

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Use usmapdata package #49

merged 7 commits into from
Feb 11, 2022

Conversation

pdil
Copy link
Owner

@pdil pdil commented Feb 9, 2022

The us_map implementation and associated mapping files have been extracted into a standalone package called usmapdata. This should greatly reduce the file size of usmap and prevent the NOTE caused by R CMD check.

This PR will track the removal of usmapdata related features including but not limited to:

  • replacing us_map() implementation
  • removing map generation scripts
  • updating documentation to refer to usmapdata where needed
  • standardizing documentation between packages so that information is not repeated unnecessarily (and to prevent future inconsistencies between documentation)

fixes #39

@pdil pdil added the enhancement A suggestion or feature that improves existing functionality label Feb 9, 2022
@pdil pdil added this to the v0.6.0 milestone Feb 9, 2022
@pdil pdil self-assigned this Feb 9, 2022
@pdil pdil changed the title Use usmapdata Use the usmapdata package Feb 9, 2022
@pdil pdil mentioned this pull request Feb 9, 2022
6 tasks
@pdil pdil changed the title Use the usmapdata package Use usmapdata package Feb 11, 2022
@pdil pdil merged commit 3fb6372 into master Feb 11, 2022
@pdil pdil deleted the feature/use-usmapdata branch February 11, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion or feature that improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract US map data to separate package
1 participant