Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maptools retiring soon #57

Closed
rsbivand opened this issue Oct 6, 2022 · 4 comments · Fixed by #71
Closed

maptools retiring soon #57

rsbivand opened this issue Oct 6, 2022 · 4 comments · Fixed by #71
Assignees
@pdil
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Milestone
v0.7.0

Comments

@rsbivand
Copy link

rsbivand commented Oct 6, 2022

See https://r-spatial.org/r/2022/04/12/evolution.html. From pkgapi analysis https://github.com/r-lib/pkgapi, this package uses elide() methods, which is used in R/transform.R. The maptools::elide() methods could be moved to sp, but I don't know whether this is worth doing given the restricted use in this package and no detected use elsewhere.
@rsbivand rsbivand added the bug A bug or issue that should be resolved label Oct 6, 2022
@pdil pdil self-assigned this Oct 27, 2022
@pdil
Copy link
Owner

pdil commented Oct 27, 2022

Thanks for the heads up! I will look into removing the maptools dependency.

@pdil pdil added tech Technical issues and pull requests not directly related to usmap functionality and removed bug A bug or issue that should be resolved labels Oct 27, 2022
@pdil pdil added this to the v0.7.0 milestone Dec 12, 2022
@cristinamullin
Copy link

Hi, I have a related question/issue. My functions that leverage usmaps seem to work when using usmaps (from github) but not the current cran version. Do you have plans to update usmaps on CRAN soon?

@cristinamullin
Copy link

This is the error I get with the current CRAN version, which goes away when usmaps is installed directly from GitHub:
maptools must be installed to use usmap_transform

@pdil
Copy link
Owner

pdil commented Feb 5, 2023

This is the error I get with the current CRAN version, which goes away when usmaps is installed directly from GitHub: maptools must be installed to use usmap_transform

@cristinamullin that's strange, since there haven't been many changes (especially related to mapping code) since the latest 0.6.1 release. Can you run sessionInfo() and post it in a new issue so I can take a look?

@rsbivand rsbivand mentioned this issue Feb 5, 2023
Closed
rsbivand added a commit to rsbivand/sp that referenced this issue Feb 5, 2023
@rsbivand
add elide from maptools, see pdil/usmap#57
37ab639
@rsbivand rsbivand mentioned this issue Feb 5, 2023
Merged
edzer added a commit to edzer/sp that referenced this issue Mar 29, 2023
@edzer
Merge pull request #129 from rsbivand/add_elide
b414d4a 
add elide from maptools, see pdil/usmap#57
@pdil pdil mentioned this issue Jun 8, 2023
Merged
@pdil pdil closed this as completed in #71 Jun 9, 2023
pdil added a commit that referenced this issue Jun 9, 2023
@pdil
Replace maptools and rgdal (#71)
132175b 
* Replaced `maptools::elide` with `sp::elide`
* Replaced `rgdal` with `sf` as `sp` now depends on it
* This should also resolve CRAN warnings/errors related to missing
functions (e.g. `maptools::elide`)

See https://r-spatial.org/r/2023/04/10/evolution3.html for more
information

fixes #57 
fixes #70
closes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Replace maptools and rgdal pdil/usmap
replace retiring packages rsbivand/usmap
3 participants
@rsbivand @pdil @cristinamullin